Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move additional CI jobs to rdmorganiser/.github #1085

Open
afuetterer opened this issue Jul 26, 2024 · 0 comments
Open

Move additional CI jobs to rdmorganiser/.github #1085

afuetterer opened this issue Jul 26, 2024 · 0 comments
Assignees

Comments

@afuetterer
Copy link
Member

afuetterer commented Jul 26, 2024

At the moment we have:

  • lint (already centrally managed)
  • test dev setup
  • test
  • end to end tests
  • coveralls completion
  • build python wheel
  • install all dependencies
  • required checks pass
  • pre-commit autoupdate

Ref: https://github.com/rdmorganiser/rdmo/blob/dev-2.2.0/.github/workflows/ci.yml

I think these can move to the central workflows location right now:

  • test dev setup (with argument "package_name": e.g. "rdmo", "rdmo-plugins-radar", ...
  • pre-commit autoupdate

The tests in this repository are highly specialized. So I see no generalization.

  • install all dependencies could be generalized if we add an "all" group, that gathers all other groups like dev, postgres etc. But it would make sense for this reason. No user would pip install rdmo[all] I guess.

Actually, I changed my mind about using pre-commit.ci. We could also move to their service and remove the pre-commit autoupdate here.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant