Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Investigate switching to build-and-inspect-python-package #1089

Open
afuetterer opened this issue Jul 29, 2024 · 0 comments
Open

ci: Investigate switching to build-and-inspect-python-package #1089

afuetterer opened this issue Jul 29, 2024 · 0 comments
Labels
github_actions Pull requests that update GitHub Actions code type:maintenance

Comments

@afuetterer
Copy link
Member

afuetterer commented Jul 29, 2024

build-and-inspect-python-package or baipp is a solid solution to building python packages in CI pipelines. It does "inspection" as well, e.g. by doing the metadata checks we do, but it also inspects the contents of the wheel.

Actually I wanted to use action, when we first decided to build the wheel in CI. But it does not work with this repo, because it fails on a couple of issues. Let me try to investigate.

One of these issues or warnings is, that there are duplicate files in the code base, maybe after running the webpack build? There are e.g. duplicated fonts files. You can verify this by checking: https://github.com/rdmorganiser/rdmo/actions/runs/10146550723#summary-28056712291

Among them are:

  • rdmo/management/static/management/fonts/fontawesome-webfont.eot
  • rdmo/projects/static/projects/fonts/fontawesome-webfont.eot

Ref: https://github.com/hynek/build-and-inspect-python-package

@afuetterer afuetterer added type:maintenance github_actions Pull requests that update GitHub Actions code labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code type:maintenance
Projects
None yet
Development

No branches or pull requests

1 participant