Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2 connection pool optimisation #2257

Closed
wants to merge 11 commits into from
Closed

Conversation

violetagg
Copy link
Member

HTTP2 stream channel pipeline optimisation

@violetagg violetagg marked this pull request as ready for review June 6, 2022 09:59
@violetagg violetagg requested a review from a team June 6, 2022 09:59
@violetagg violetagg added type/bug A general bug type/enhancement A general enhancement labels Jun 6, 2022
@violetagg violetagg added this to the 1.0.20 milestone Jun 6, 2022
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, though I added a few small comments

@violetagg
Copy link
Member Author

@reactor/netty-team I added 3 additional changes PTAL

Cache H2CUpgradeHandler context
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

violetagg added a commit that referenced this pull request Jun 8, 2022
Cache Http2FrameCodec/Http2MultiplexHandler/H2CUpgradeHandler context.
Obtain the negotiated application level protocol once.

Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
violetagg added a commit that referenced this pull request Jun 8, 2022
violetagg added a commit that referenced this pull request Jun 8, 2022
Http2StreamFrameToHttpObjectCodec can be shared
Http2StreamBridgeClientHandler can be shared

Related to #2151 and #2262
violetagg added a commit that referenced this pull request Jun 8, 2022
violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Copy link
Member Author

@simonbasle @pderop Thanks for the review!

violetagg added a commit that referenced this pull request Jun 8, 2022
@violetagg
Copy link
Member Author

Changes were applied to 1.0.x and merged in main

@violetagg violetagg closed this Jun 8, 2022
@violetagg violetagg deleted the http2-optimization branch June 8, 2022 10:47
pderop added a commit to pderop/reactor-netty that referenced this pull request Jun 8, 2022
violetagg added a commit that referenced this pull request Jun 14, 2022
@violetagg violetagg removed the type/bug A general bug label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
3 participants