From c15bb99190a6efaf32b9856db22d70bef54672f8 Mon Sep 17 00:00:00 2001 From: Wen Zhou Date: Tue, 4 Jun 2024 10:02:16 +0200 Subject: [PATCH] cherry-pick: set DSC phase to Error Than Ready if component reconcile has error Signed-off-by: Wen Zhou --- controllers/datasciencecluster/datasciencecluster_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controllers/datasciencecluster/datasciencecluster_controller.go b/controllers/datasciencecluster/datasciencecluster_controller.go index ef691b0ce71..c2661926b06 100644 --- a/controllers/datasciencecluster/datasciencecluster_controller.go +++ b/controllers/datasciencecluster/datasciencecluster_controller.go @@ -269,7 +269,7 @@ func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.R instance, err = status.UpdateWithRetry(ctx, r.Client, instance, func(saved *dsc.DataScienceCluster) { status.SetCompleteCondition(&saved.Status.Conditions, status.ReconcileCompletedWithComponentErrors, fmt.Sprintf("DataScienceCluster resource reconciled with component errors: %v", componentErrors)) - saved.Status.Phase = status.PhaseReady + saved.Status.Phase = status.PhaseError }) if err != nil { r.Log.Error(err, "failed to update DataScienceCluster conditions with incompleted reconciliation")