Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to delete Sandbox instance #66

Open
deboer-tim opened this issue May 17, 2023 · 3 comments
Open

No way to delete Sandbox instance #66

deboer-tim opened this issue May 17, 2023 · 3 comments
Assignees
Labels
kind/enhancement ✨ New feature or request

Comments

@deboer-tim
Copy link
Contributor

If I successfully create a Sandbox instance, the Delete button is disabled. To delete I need to wait for the status not to be running (e.g. wait until tomorrow?).

It should be possible to stop/delete the instance whenever I am done using it.

@dgolovin
Copy link
Collaborator

@deboer-tim I agree, but the provider API controls lifecycle commands (delete is lifecycle command) based on connection status. Delete is enabled only when connections is stopped or unknown.

@dgolovin dgolovin self-assigned this May 18, 2023
@dgolovin dgolovin added the kind/enhancement ✨ New feature or request label May 18, 2023
@deboer-tim
Copy link
Contributor Author

Ok, so maybe we need an API update to distinguish between local instances (that can be started/stopped and deleted) vs remote ones where you can just drop the connection (delete the context)?

@dgolovin
Copy link
Collaborator

That is an option.

In general Delete should probably be always enabled, and podman-desktop should execute Stop command for connection/image/extension if running before executing Delete command.

Another one would be:

  1. Do not restrict provider to specific set of commands
  2. Let provider configure commands that would be shown for connections
  3. Let UI render buttons based on commands state (controlled by provider)

This way for example I would be able to provide custom commands for Developer Sandbox Connection, like 'Refresh authentication token' when sandbox cluster is running but token is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants