Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about EndOfSentence: Found invalid end of sentence "'.". #832

Open
dylan-chong opened this issue Apr 30, 2018 · 1 comment
Open

Comments

@dylan-chong
Copy link

This tool was created using a thing called 'Hello'.

EndOfSentence: Found invalid end of sentence "'.".


Are we sure that the above is actually grammatically incorrect? It seems like a perfectly valid sentence to me, and i was not able to find a website that says this is not valid

@edwardwoodward
Copy link

It is not grammatically incorrect. It's just a question of style.
In US English, the "correct" style is to place a comma or full stop (period) inside the quotation marks, even if it is not actually part of the quotation. RedPen has adopted this US style. Personally, I think that rule is illogical, and I would recommend ignoring it (but I'm British...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants