Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cosmos/gogoproto instead of gogo/protobuf #1449

Open
4 tasks
Tracked by #2068
ryanchristo opened this issue Aug 31, 2022 · 4 comments
Open
4 tasks
Tracked by #2068

Use cosmos/gogoproto instead of gogo/protobuf #1449

ryanchristo opened this issue Aug 31, 2022 · 4 comments

Comments

@ryanchristo
Copy link
Member

Summary

We are currently using gogo/protobuf and a replace directive that points to a regen fork of the library. We should update to use the fork maintained by the cosmos core devs and remove the replace directive.

For reference: cosmos/cosmos-sdk#10925 cosmos/cosmos-sdk#13070

Problem Definition

Using a replace directive is confusing and prevents users from using go install.

Proposal

Use cosmos/gogoproto fork of gogo/protobuf instead of gogo/protobuf with replace directive.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@clevinson
Copy link
Member

Once #1478 get's merged we should be able to move forward with this.

@technicallyty
Copy link
Contributor

we'll also have to wait for the next release of cosmos-sdk which will include the updated import. otherwise we will still need the replace directive in our repo

see error below

go mod tidy
go: finding module for package github.com/gogo/protobuf/grpc
github.com/regen-network/regen-ledger/types/testutil/cli imports
        github.com/cosmos/cosmos-sdk/client imports
        github.com/gogo/protobuf/grpc: module github.com/gogo/protobuf@latest found (v1.3.2), but does not contain package github.com/gogo/protobuf/grpc

@technicallyty
Copy link
Contributor

technicallyty commented Oct 27, 2022

Update: our current sdk version v0.46.3 does not contain the cosmos/gogo migration, so the replace directive cannot be removed. The latest patch version, v0.46.10, does not contain the update either. the next release will likely include the change to cosmos gogo.

as @ryanchristo mentioned in standup, the dragonberry patch introduced another replace directive, so we can probably just mark this as iceboxed and nice to have once the new sdk version comes out.

@ryanchristo
Copy link
Member Author

Blocked until we upgrade to cosmos sdk v0.47

@ryanchristo ryanchristo mentioned this issue Oct 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants