-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cosmos/gogoproto instead of gogo/protobuf #1449
Comments
Once #1478 get's merged we should be able to move forward with this. |
we'll also have to wait for the next release of cosmos-sdk which will include the updated import. otherwise we will still need the replace directive in our repo see error below ❯ go mod tidy
go: finding module for package github.com/gogo/protobuf/grpc
github.com/regen-network/regen-ledger/types/testutil/cli imports
github.com/cosmos/cosmos-sdk/client imports
github.com/gogo/protobuf/grpc: module github.com/gogo/protobuf@latest found (v1.3.2), but does not contain package github.com/gogo/protobuf/grpc |
Update: our current sdk version as @ryanchristo mentioned in standup, the dragonberry patch introduced another replace directive, so we can probably just mark this as iceboxed and nice to have once the new sdk version comes out. |
Blocked until we upgrade to cosmos sdk v0.47 |
Summary
We are currently using gogo/protobuf and a replace directive that points to a regen fork of the library. We should update to use the fork maintained by the cosmos core devs and remove the replace directive.
For reference: cosmos/cosmos-sdk#10925 cosmos/cosmos-sdk#13070
Problem Definition
Using a replace directive is confusing and prevents users from using
go install
.Proposal
Use cosmos/gogoproto fork of gogo/protobuf instead of gogo/protobuf with replace directive.
For Admin Use
The text was updated successfully, but these errors were encountered: