Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module incorrectly marked dead when contains non-dead type and submodule definitions #157

Open
sim642 opened this issue May 17, 2022 · 1 comment

Comments

@sim642
Copy link

sim642 commented May 17, 2022

Running reanalyze 389dd68 on Goblint goblint/analyzer@a544002 revealed the following.

In the terminal output there's a dead module warning:

  Warning Dead Module
  File "./gobview/src/state/gvMessages.ml", line 1, characters 0-0
  +gvMessages is a dead module as all its items are dead.

  Warning Dead Value
  File "./gobview/src/state/gvMessages.ml", lines 22-28, characters 0-18
  +filter_by_line is never used
  <-- line 22
    List.filter pred [@@dead "+filter_by_line"]

Although the only value filter_by_line is indeed dead, it also contains a type t and module Message which are not. Therefore the GvMessages module should not be considered dead overall.

@cristianoc
Copy link
Collaborator

Not sure if include is treated correctly, for the inner module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants