Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change storage location of offline mode from in-memory array to localStroage #211

Open
mohitt opened this issue Jul 28, 2017 · 1 comment
Labels

Comments

@mohitt
Copy link

mohitt commented Jul 28, 2017

Hi,

Can I extend this module, to allow injection of the storage location of offline events. So, that as per the application need developer can inject. By default it would in-memory array only. So, that it stays backward compatible.

Let me know your thoughts.

Regards
Mohit Thakral

@justinsa
Copy link
Collaborator

justinsa commented Aug 1, 2017

Do you want to extend it with localStorage and/or sessionStorage as per HTML5?

If you keep it fully backwards compatible, add an acceptable suite of unit tests, and ensure there is no requirement on another module / package, then absolutely. You just need to submit a PR for the change and I will be happy to code review, provide feedback, and assist you in getting the change in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants