Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqrts in Marginal2D::sample() sometimes cause NaNs #4

Open
mmp opened this issue Nov 7, 2019 · 0 comments
Open

sqrts in Marginal2D::sample() sometimes cause NaNs #4

mmp opened this issue Nov 7, 2019 · 0 comments

Comments

@mmp
Copy link

mmp commented Nov 7, 2019

The values passed to the std::sqrts in there probably should be clamped to zero; I ran into a case where a NaN was generated here due to a sample very close to one and an unlucky combination of values in the expression passed to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmp