-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Pinning pod removes extra targets in podfile #1
Comments
@vethan , As is documented in the onesignal-expo-plugin and surfaced in this issue, it's important to always put that plugin first! While that is the case, I'm not able to reproduce the issue regardless with: "plugins": [
[
"expo-pod-pinner",
{
"targetName": "StickerSmash",
"pods": [
{
"BoringSSL-GRPC": "0.0.24"
}
]
}
],
["onesignal-expo-plugin", {
"mode": "development"
}]
] Can you please share your Podfile? |
I hadn't seen that it had to go first, probably just speed reading when I was originally setting up a while back! Fun that the problems only cropped up with the firebase faff! I suppose that was the real problem after all. Just for info: Podfile with pinning first:
And with pinning second/Last
|
Interesting. I've tried it multiple times and can't repro. What do the logs say in your console? |
Weird... could be some odd quirk? I tried doing a prebuild with a minimal set of plugins on my project (just pinner + onesignal in my plugins array) and it still repro'd. If it's just me, and the fix is "put pinner later" it's probably not a big deal
|
Ah interesting. I don't see the onesignal logs:
|
What happened?
When pinning a pod version, if a later plugin changes the podfile, these changes are lost
Steps to reproduce?
What did you expect to happen?
Plugin order to not change behaviour
Expo Pod Pinner Plugin version
1.0.0
Platform
iOS
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: