Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim 15.8 for ZeeOS (x86_64) #441

Open
8 tasks done
zeetim opened this issue Sep 6, 2024 · 9 comments
Open
8 tasks done

Shim 15.8 for ZeeOS (x86_64) #441

zeetim opened this issue Sep 6, 2024 · 9 comments
Labels
contacts verified OK Contact verification is complete here (or in an earlier submission) easy to review This submission might be a good place to start for an inexperienced reviewer extra review wanted Initial review(s) look good, another review desired new vendor This is a new vendor

Comments

@zeetim
Copy link

zeetim commented Sep 6, 2024

Confirm the following are included in your repo, checking each box:

  • completed README.md file with the necessary information
  • shim.efi to be signed
  • public portion of your certificate(s) embedded in shim (the file passed to VENDOR_CERT_FILE)
  • binaries, for which hashes are added to vendor_db ( if you use vendor_db and have hashes allow-listed )
  • any extra patches to shim via your own git tree or as files
  • any extra patches to grub via your own git tree or as files
  • build logs
  • a Dockerfile to reproduce the build of the provided shim EFI binaries

What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/zeetim/shim-review/tree/zeetim-shim-x64-20240906


What is the SHA256 hash of your final SHIM binary?


26cb646f44e7592bfce836206f2dc81f9aa80b7cdcbd1b440e5b2e49e4962a6f shimx64.efi


What is the link to your previous shim review request (if any, otherwise N/A)?


N/A. This is our first application


If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?


N/A. This is our first application

@steve-mcintyre steve-mcintyre added new vendor This is a new vendor contact verification pending Contact verification emails have been sent, waiting on response labels Sep 8, 2024
@steve-mcintyre
Copy link
Collaborator

Contact verification emails sent

@Kal42
Copy link

Kal42 commented Sep 9, 2024

Hi,

Verification for [email protected] :

eunuchs drowned milkier awkwardness dilute coiffuring deserve similarities lingoes trotters

@zeetim
Copy link
Author

zeetim commented Sep 9, 2024

Hello,
Contact verification for [email protected]:
mulishness Ewing furnish calamity emblems remounts infinitesimals Swansea fusing protrusion

@steve-mcintyre steve-mcintyre added contacts verified OK Contact verification is complete here (or in an earlier submission) and removed contact verification pending Contact verification emails have been sent, waiting on response labels Sep 9, 2024
@evilteq
Copy link

evilteq commented Sep 23, 2024

Just to clarify: "We use an ephemeral key to sign kernel modules" or "Kernel modules are signed using the same vendor keypair used inside shim image." ?

@zeetim
Copy link
Author

zeetim commented Sep 24, 2024

Just to clarify: "We use an ephemeral key to sign kernel modules" or "Kernel modules are signed using the same vendor keypair used inside shim image." ?

We are using a different keypair to sign kernel modules. Vendor keypair included in shim image is only used to sign mokmanager (mmx64.efi), fallback (fbx64.efi), grub (grubx64.efi) and kernel image (bzImage).

@evilteq
Copy link

evilteq commented Sep 24, 2024

And that key is unique for each release (ephemeral) or is it fixed?

@zeetim
Copy link
Author

zeetim commented Sep 24, 2024

And that key is unique for each release (ephemeral) or is it fixed?

The key is unique for each release

@evilteq
Copy link

evilteq commented Sep 27, 2024

Shim is pretty much by the book, only one patch to make it NX and non-NX (only the the NX is used).
Reproduced it with the same sha256.

Certificate inside is valid for 30 years, 4K, key inside a yubike, these details:
Subject: C = FR, ST = Ile-de-France, L = Vitry-Sur-Seine, O = ZEETIM SAS, OU = ZEETIM SAS CERTIFICATE AUTHORITY, CN = ZEETIM SAS ROOT CA

Grub has many patches, but all known. (I found them exactly in the ubuntu sources).

I guess there is a mistake in the grub .sbat as it says 2.06 version, then states to be 2.12. I guess its just forgotten to add the new one for this review?

Looks good to me!

@steve-mcintyre steve-mcintyre added extra review wanted Initial review(s) look good, another review desired easy to review This submission might be a good place to start for an inexperienced reviewer labels Sep 30, 2024
@zeetim
Copy link
Author

zeetim commented Oct 1, 2024

I guess there is a mistake in the grub .sbat as it says 2.06 version, then states to be 2.12. I guess its just forgotten to add the new one for this review?

Thank you for your review! We have fixed the grub sbat mismatch in our repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contacts verified OK Contact verification is complete here (or in an earlier submission) easy to review This submission might be a good place to start for an inexperienced reviewer extra review wanted Initial review(s) look good, another review desired new vendor This is a new vendor
Projects
None yet
Development

No branches or pull requests

4 participants