Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shim 15.8 for Oracle Solaris 11.4 #447

Open
8 tasks done
daveminer1 opened this issue Oct 10, 2024 · 3 comments
Open
8 tasks done

shim 15.8 for Oracle Solaris 11.4 #447

daveminer1 opened this issue Oct 10, 2024 · 3 comments
Labels
contact verification needed Contact verification is needed for this review

Comments

@daveminer1
Copy link

daveminer1 commented Oct 10, 2024

Confirm the following are included in your repo, checking each box:

  • completed README.md file with the necessary information
  • shim.efi to be signed
  • public portion of your certificate(s) embedded in shim (the file passed to VENDOR_CERT_FILE)
  • binaries, for which hashes are added to vendor_db ( if you use vendor_db and have hashes allow-listed )
  • any extra patches to shim via your own git tree or as files
  • any extra patches to grub via your own git tree or as files
  • build logs
  • a Dockerfile to reproduce the build of the provided shim EFI binaries

What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/daveminer1/shim-review/tree/oraclesolaris-shim-x86_64-20241010


What is the SHA256 hash of your final SHIM binary?


b098fb90bff86509aacff0e5bc197583e7e77968cc64da4d41d310fb4eab3087 shimx64.efi


What is the link to your previous shim review request (if any, otherwise N/A)?


N/A


If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?


N/A

@es-fabricemarie
Copy link

  • build reproduces fine with dockerfile and docker build .
    b098fb90bff86509aacff0e5bc197583e7e77968cc64da4d41d310fb4eab3087  /usr/share/shim/15.8-1.0.3.el9/x64/shimx64.efi
    
  • shim built from 15.8 official tarball, unpatched
  • NX bit is not set
  • SBAT entries look alright
  • OpenPGP keys:
    • Alan Coopersmith's key found on Ubuntu OpenPGP key server:
      • https://keyserver.ubuntu.com/pks/lookup?search=4A193C06D35E7C670FA4EF0BA2FB9E081F2D130E&fingerprint=on&op=index
      • expires: 2028-04-19, key is cross-signed
    • Dave Miner's key not found on Ubuntu/MIT OpenPGP key servers, no key expiry. Key is cross-signed.
  • EV Code Signing cert used:
    • RSA 3072 bit
    • Issuer: C=US, O=DigiCert, Inc., CN=DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1
    • Subject: jurisdictionC=US, jurisdictionST=Delaware, businessCategory=Private Organization, serialNumber=2101822, C=US, ST=California, L=Redwood City, O=Oracle America, Inc., CN=Oracle America, Inc.
    • Expires in April next year: Not After : Apr 2 23:59:59 2025 GMT

Issues:

  • DISABLE_EBS_PROTECTION is set so official reviewer will have to take a deeper look.
  • grub2 is patched (build glue and zfs among others). More scrutiny by core team member is advised.

@steve-mcintyre steve-mcintyre added the contact verification needed Contact verification is needed for this review label Oct 14, 2024
@jsetje
Copy link
Collaborator

jsetje commented Oct 15, 2024

Since I work for the same company as the submitters, I don't count as a reviewer in this case. However, I looked this over in some detail before it was submitted.

DISABLE_EBS_PROTECTION is expected, since with the custom ELF validation code nothing will call back into shim lock protocol to have shim validate anything additional.

@daveminer1
Copy link
Author

My key is present on pgp.mit.edu:

Search results for 'oracle miner dave com'

Type bits/keyID Date User ID

pub 256E/8C450938 2024-07-23 Dave Miner [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contact verification needed Contact verification is needed for this review
Projects
None yet
Development

No branches or pull requests

4 participants