Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets " name " should not be exceed 64 characters #618

Open
marwa-benhassine opened this issue May 3, 2023 · 3 comments
Open

Presets " name " should not be exceed 64 characters #618

marwa-benhassine opened this issue May 3, 2023 · 3 comments
Assignees
@CherifAmine
Labels
component: presets Changes related to predefined settings or configurations. type: bug Indicates that the issue or pull request addresses a bug or error.

Comments

@marwa-benhassine
Copy link
Contributor

Describe the bug

Preset "name " cannot be created with more than 64 characters .
To Reproduce

Steps to reproduce the behavior:

1.Start the web app
2.Go to the Presets pages .

Expected behavior

A popup should appear when creating presets with more than 64 characters.

Screenshots

image

Desktop (please complete the following information):

OS: Windows

Browser: Chrome/Edge/Firefox
@marwa-benhassine marwa-benhassine added the type: bug Indicates that the issue or pull request addresses a bug or error. label May 3, 2023
@CherifAmine CherifAmine self-assigned this May 4, 2023
This was referenced May 5, 2023
Merged
Merged
@GhaziTriki GhaziTriki added this to the 0.14.0 milestone May 5, 2023
@GhaziTriki GhaziTriki added the component: presets Changes related to predefined settings or configurations. label May 5, 2023
@marwa-benhassine
Copy link
Contributor Author

preset name cannot be edited with more than 64 characters

image

@GhaziTriki GhaziTriki removed this from the 0.14.0 milestone Jul 3, 2023
@GhaziTriki
Copy link
Member

Any data validation should happen in the backend and in the frontend.

@GhaziTriki GhaziTriki mentioned this issue Jul 3, 2023
Closed
@CherifAmine
Copy link
Contributor

Fix in PR : #848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherifAmine CherifAmine

Labels
component: presets Changes related to predefined settings or configurations. type: bug Indicates that the issue or pull request addresses a bug or error.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GhaziTriki @CherifAmine @marwa-benhassine