Add config variable for BKE turbulent conduction suppression

[wtbarnes]

See rice-solar-physics/HYDRAD#78

To me, it looks like there are four variables here that need to be added,

• USE_BKE -- boolean, whether to use this option
• BKE_L_T -- float,
• BKE_S_R -- float
• BKE_2L_R2 -- float

[jwreep]

What specifically needs to be done to implement this? Add these to the template?

I'm willing to give it a shot.

[wtbarnes]

So I think the first thing to work out is what are the variables that define the BKE conduction option? Are they the things I listed above? And then to work out which header file they go in. I'm assuming HYDRAD/source/config.h but perhaps that isn't correct.

Then it's just a matter of adding the logic to the template. If it is the HYDRAD config.h, it would be this one: https://github.com/rice-solar-physics/pydrad/blob/master/pydrad/configure/templates/hydrad.config.h. It could be something as simple as adding the following:

{% if general.bke %}
#define USE_BKE
#define BKE_L_T {{ general.bke.l_t }}
#define BKE_S_R {{ general.bke.s_r }}
#define BKE_2L_R2 {{ general.bke.2l_r2 }}
{% endif %}

This assume the existence of a bke entry in the config dictionary which is itself a dictionary with entries for l_t, s_r, and 2l_r2. It would be nice to also have more descriptive names for these variables and to document what they are.

[sjbradshaw]

l_t is the turbulence scale length. s_r is the center of the turbulent region. l_r is the Gaussian width of the turbulent region (centered at s_r) and so 2l_r2 is 2 x l_r^2 which is the quantity in the denominator of the exponential index used to calculate the distribution.Sent via the Samsung Galaxy S7 active, an AT&T 4G LTE smartphone -------- Original message --------From: Will Barnes <[email protected]> Date: 12/18/20 12:12 AM (GMT-06:00) To: rice-solar-physics/pydrad <[email protected]> Cc: Subscribed <[email protected]> Subject: Re: [rice-solar-physics/pydrad] Add config variable for BKE turbulent conduction suppression (#120) So I think the first thing to work out is what are the variables that define the BKE conduction option? Are they the things I listed above? And then to work out which header file they go in. I'm assuming HYDRAD/source/config.h but perhaps that isn't correct. Then it's just a matter of adding the logic to the template. If it is the HYDRAD config.h, it would be this one: https://github.com/rice-solar-physics/pydrad/blob/master/pydrad/configure/templates/hydrad.config.h. It could be something as simple as adding the following: {% if general.bke %} #define USE_BKE #define BKE_L_T {{ general.bke.l_t }} #define BKE_S_R {{ general.bke.s_r }} #define BKE_2L_R2 {{ general.bke.2l_r2 }} {% endif %} This assume the existence of a bke entry in the config dictionary which is itself a dictionary with entries for l_t, s_r, and 2l_r2. It would be nice to also have more descriptive names for these variables and to document what they are. —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.