Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache should not be regenerated on PhotoSize change that only changed "increment_count" #95

Open
tbabej opened this issue Aug 6, 2014 · 1 comment

Comments

@tbabej
Copy link
Contributor

tbabej commented Aug 6, 2014

When you save a PhotoSize, the whole photo cache gets regenerated. While this makes sense for changes in other attributes, such as width or watermarks, photo cache should not be regenared if you only switched off/on the increment_count.

I propose that we extend PhotoSize model so that it knows what attributes were changed (as suggested here http://stackoverflow.com/a/13842223 ) and then regenarate the cache only if necessary.

I can submit a pull request if you approve.

@richardbarran
Copy link
Owner

That would make sense and improve performance - pull requests welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants