Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary calls to select_dmi() #1092

Open
en-sc opened this issue Jun 14, 2024 · 0 comments
Open

Unnecessary calls to select_dmi() #1092

en-sc opened this issue Jun 14, 2024 · 0 comments
Labels
Good First Issue This label marks the first good issue for anyone willing to contribute to the project.

Comments

@en-sc
Copy link
Collaborator

en-sc commented Jun 14, 2024

As noted by @JanMatCodasip in #1089:

The calls to select_dmi() in assert_reset(), deassert_reset() and read_memory_progbuf() appear to be redundant. The underlying batch API or dm_read/dm_write() API should always take care of that.
@en-sc en-sc added the Good First Issue This label marks the first good issue for anyone willing to contribute to the project. label Jun 14, 2024
@en-sc en-sc mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This label marks the first good issue for anyone willing to contribute to the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@en-sc