From d35c66a734454cff4a68b91cb560c8ce81e00cec Mon Sep 17 00:00:00 2001 From: Joshua Yeong Date: Fri, 6 Sep 2024 02:21:22 +0800 Subject: [PATCH 1/4] base: Reorder Subsection Move 'RPMI Implemetation IDs' subsection to the top of the section before 'Notifications' subsection. Signed-off-by: Joshua Yeong --- src/srvgrp-base.adoc | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/srvgrp-base.adoc b/src/srvgrp-base.adoc index 7de6577..0c5109d 100644 --- a/src/srvgrp-base.adoc +++ b/src/srvgrp-base.adoc @@ -64,6 +64,18 @@ The below table lists the services in this group: | NORMAL_REQUEST |=== +==== RPMI Implementation IDs +[#table_base_rpmi_impl_id] +.RPMI Implementation IDs +[cols="2, 3a", width=100%, align="center", options="header"] +|=== +| Implementation ID +| Name + +| +| +|=== + [#base-notifications] ==== Notifications This service is used by the platform microcontroller to send the asynchronous @@ -534,15 +546,3 @@ service to discover this capability and then use this service. !=== - Other errors <> |=== - -==== RPMI Implementation IDs -[#table_base_rpmi_impl_id] -.RPMI Implementation IDs -[cols="2, 3a", width=100%, align="center", options="header"] -|=== -| Implementation ID -| Name - -| -| -|=== \ No newline at end of file From 5b87a9eec3a44b0356b8a673bddcdb80b6085546 Mon Sep 17 00:00:00 2001 From: Joshua Yeong Date: Fri, 6 Sep 2024 02:23:25 +0800 Subject: [PATCH 2/4] Ras: Reorder Subsection Move 'Error Source Descriptor Format' subsection to the top of the section before 'Notifications' subsection. Signed-off-by: Joshua Yeong --- src/srvgrp-ras-agent.adoc | 52 +++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/src/srvgrp-ras-agent.adoc b/src/srvgrp-ras-agent.adoc index c854c95..a3cd0dd 100644 --- a/src/srvgrp-ras-agent.adoc +++ b/src/srvgrp-ras-agent.adoc @@ -43,6 +43,32 @@ Below table lists the services in this group: | NORMAL_REQUEST |=== +==== Error Source Descriptor Format +===== ACPI Systems +For systems that support ACPI/APEI, the format of the error source descriptor +is as defined in ACPI specification v6.4 or above, (GHESv2) cite:[ACPI]. +If the value of `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]` is `0`, it indicates that the +error source descriptor format is GHESv2. + +The RAS agent populates the error source descriptor fields according to the +error source specified by `RAS_ERR_SRC_ID`. + +NOTE: The error source descriptor has an `error_status_structure` field which +is a generic address structure (`GAS`) as defined in ACPI v6.4 (GHESv2) +cite:[ACPI]. This field specifies the location of a register that contains the +physical address of a block of memory that holds the error status data for the +specified error source. This block of memory is referred to as +`error_status_block`. The allocation of `error_status_block` is platform +dependent and is done by the RAS agent. The physical address of +`error_status_block` is stored in the `error_status_structure` field of the +error source descriptor being returned. + +===== Non-ACPI Systems +RAS is not standardized for non-ACPI systems. Such systems may define custom +format for an error source descriptor. The type of custom error source +descriptor format can be read from `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]`. The +values from 1 to 15 are reserved for custom format types. + [#ras-notifications] ==== Notifications This service group does not support any event for notification. @@ -300,29 +326,3 @@ implementation specific. | uint8 | Full or partial descriptor N is equal to the `RETURNED` bytes in this request. |=== - -==== Error Source Descriptor Format -===== ACPI Systems -For systems that support ACPI/APEI, the format of the error source descriptor -is as defined in ACPI specification v6.4 or above, (GHESv2) cite:[ACPI]. -If the value of `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]` is `0`, it indicates that the -error source descriptor format is GHESv2. - -The RAS agent populates the error source descriptor fields according to the -error source specified by `RAS_ERR_SRC_ID`. - -NOTE: The error source descriptor has an `error_status_structure` field which -is a generic address structure (`GAS`) as defined in ACPI v6.4 (GHESv2) -cite:[ACPI]. This field specifies the location of a register that contains the -physical address of a block of memory that holds the error status data for the -specified error source. This block of memory is referred to as -`error_status_block`. The allocation of `error_status_block` is platform -dependent and is done by the RAS agent. The physical address of -`error_status_block` is stored in the `error_status_structure` field of the -error source descriptor being returned. - -===== Non-ACPI Systems -RAS is not standardized for non-ACPI systems. Such systems may define custom -format for an error source descriptor. The type of custom error source -descriptor format can be read from `RAS_GET_ERR_SRC_DESC.FLAGS[3:0]`. The -values from 1 to 15 are reserved for custom format types. From 3b4d237d55ed0c7fd3d673340a814b09d7f698c3 Mon Sep 17 00:00:00 2001 From: Joshua Yeong Date: Fri, 6 Sep 2024 02:24:11 +0800 Subject: [PATCH 3/4] message-protocol: Fix service id to subscribe event Update subscribing notification service id from 0x00 to 0x01. Signed-off-by: Joshua Yeong --- src/message-protocol.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/message-protocol.adoc b/src/message-protocol.adoc index 2d6a8ce..6e246b7 100644 --- a/src/message-protocol.adoc +++ b/src/message-protocol.adoc @@ -209,7 +209,7 @@ events may also have additional data associated with them. Any action required on behalf of an event depends on the application processor. <> shows the notification message format. -Each service group has one service with a fixed `SERVICE_ID=0x00` to subscribe +Each service group has one service with a fixed `SERVICE_ID=0x01` to subscribe to events. By default the event notification is disabled for each service group and the application processor must subscribe to the supported events in each service group to receive notification messages. Notification messages are From dec4c0a1014bbe381aa1332f037440027e6b4e55 Mon Sep 17 00:00:00 2001 From: Joshua Yeong Date: Fri, 6 Sep 2024 02:37:34 +0800 Subject: [PATCH 4/4] message-protocol: Update vendor specific error code Update sign of vendor specific error code. Signed-off-by: Joshua Yeong --- src/message-protocol.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/message-protocol.adoc b/src/message-protocol.adoc index 6e246b7..f3bf147 100644 --- a/src/message-protocol.adoc +++ b/src/message-protocol.adoc @@ -349,5 +349,5 @@ violates the extension specification or the extension version mismatch. | Input/Output error. | | -14 to -127 | _Reserved_ -| | > -127 | _Vendor specific_ +| | < -127 | _Vendor specific_ |===