From 1b1cb6897eea1a899bf086acdd371cfed3588973 Mon Sep 17 00:00:00 2001 From: Rahul Pathak Date: Thu, 7 Nov 2024 22:36:02 +0530 Subject: [PATCH] rpmi/clock: Reorder flags bits and remove duplicate error code Signed-off-by: Rahul Pathak --- src/srvgrp-clock.adoc | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/srvgrp-clock.adoc b/src/srvgrp-clock.adoc index e7018ba..e7f49a4 100644 --- a/src/srvgrp-clock.adoc +++ b/src/srvgrp-clock.adoc @@ -205,7 +205,7 @@ described in <>. ==== Service: CLK_GET_NUM_CLOCKS (SERVICE_ID: 0x02) This service is used to query the number of clocks available in the system. All supported clocks in the system are designated by an integer identifier -called `CLOCK_ID`. `CLOCK_ID` are sequential starting from `0`. +called `CLOCK_ID`. [#table_clock_getnumclocks_request_data] .Request Data @@ -393,10 +393,7 @@ to get all the clock rates. In case the `CLOCK_FORMAT` is a linear range the ! Service completed successfully. ! RPMI_ERR_INVALID_PARAM -! `CLOCK_ID` is invalid. - -! RPMI_ERR_INVALID_PARAM -! `CLOCK_RATE_INDEX` is invalid. +! `CLOCK_ID` or `CLOCK_RATE_INDEX` is invalid. !=== - Other errors <> @@ -579,7 +576,11 @@ This service is used to set the clock rate of a specific clock. ! Bits ! Description -! [31:30] ! Clock rate round up/round down +! [31:2] +! _Reserved_ and must be `0`. + +! [1:0] +! Clock rate rounding mode ---- 0b00: Round down 0b01: Round up @@ -588,8 +589,6 @@ This service is used to set the clock rate of a specific clock. In Auto mode the platform can autonomously chooses a supported rate closest to the requested rate. ---- - -! [29:0] ! _Reserved_ and must be `0`. !=== | 2