Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Pluggy should be in install_requires; pytest shouldn’t #64

Open
alexshpilkin opened this issue Dec 25, 2022 · 3 comments
Open

Pluggy should be in install_requires; pytest shouldn’t #64

alexshpilkin opened this issue Dec 25, 2022 · 3 comments

Comments

@alexshpilkin
Copy link
Contributor

Since #8, there has been a dependency on pluggy which is not listed in install_requires / requirements.txt.

On the other hand, as best as I can tell, pytest is only required to run tests (which is reasonable), yet is present in install_requires instead of only in tests_require, thus requiring every riscv_isac user to have it on their computer (which is not). It would be better to move it to the latter.

@pawks
Copy link
Collaborator

pawks commented Dec 27, 2022

@alexshpilkin Thanks for filing the issue. Would you be willing to raise a PR for the same?

@alexshpilkin
Copy link
Contributor Author

@pawks I’m fine doing that, sure. Do you want to make a separate test_requirements.txt or just special-case pytest for now? (I could even imagine comment-separated sections in the current requirements.txt file, but that sounds more fancy that this tiny problem is worth, honestly.)

@pawks
Copy link
Collaborator

pawks commented Dec 29, 2022

Its better to have a separate test_requirements.txt than try to separate the requirements.txt into sections.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants