-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instruction names #1638
Comments
Aren't all of these instruction mnemonics the exact ones clearly used in the Unpriv spec (and hence need no discussion or agreement on making them official since they are already official and part of ratified specs)? |
The mnemonics are all present. I want to add human-readable names to the ISA specification. So "slli" would have an associated name like "shift left logical immediate". In its current form, the ISA specification has very few clearly distinguished such names. |
It seems that the RISC-V Unified Database project is also busy adding instruction names, so I've added the names they chose to the table:
|
I proposed some annotations to the RISC-V Sail code which added human-readable names for each mnemonic, starting with just those in the "base" set for now.
Feedback to me for that PR included that many of the proposed instruction names weren't official names already expressed in the RISC-V ISA specification.
This issue is to try to address that concern by getting agreement on names for the mnemonics (base only for now), and adding them in some form to the specification. First step is to get agreement on instruction names. Is there a process to get 'official' agreement? Should I encode the names as changes to the specification in a PR so that it can be reviewed?
Below is a table that lists:
model/riscv_insts_base.sail
).It's anecdotal, but there is reasonable agreement among the 3 ad-hoc naming attempts.
The text was updated successfully, but these errors were encountered: