-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizer: push any filter down to storage #794
Comments
What's the difference between filtering arbitrary expression on the executor and filtering on the storage? Is that really helpful to push it down? I can only understand that range filters on primary key are more efficient. That's why I didn't add rules to push any filter down. 🤪 |
Filters with high selectivity can also be super efficient if it's pushed down to the storage side. Consider two examples:
|
I see. Thanks for the explanation. Then we should revert some changes from #786, where I removed the code for filtering in |
related to #794 #834 , add some new rules and change scan's default filter to true(this make it match with the "filter-scan" rule) Signed-off-by: kysshsy <[email protected]>
The current storage iterator supports pushing down any filter. We may add an optimizer rule for that (I myself is working on it...)
The text was updated successfully, but these errors were encountered: