-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A 'barLine' in the 'corr' element messes up the rendering in Verovio #2026
Comments
Yes, this is unfortunately expected. To do the layout, Verovio needs to cuts the whole section into smaller chunks - basically invisible measures. As it stands, it relies on Obviously, all this will not work with the |
I would think that having a |
I see.
To solve at least some of the situations, when possible, I am moving the barline outside of the I think that the solution you propose, @lpugin, will work: excluding barlines within editorial markup as possible cutting point. I think that this situation—having a dotted barline falling within a corr element—won't happen very often, so this proposed solution might be enough. I am including @karend27 in this discussion. What do you think about the "dotted barline falling within corr" situation? do you think it can happen often? (considering I am moving it out when it is the last thing in the corr) |
Well, you are right that it doesn't make sense if you are adding barlines as an editorial correction. However, we are not adding them with that idea in mind (thinking that the scribe forgot to add one), we are adding them to show groups of notes and facilitate the visualization of the note alignment in the different voices. The idea is that we have a scored-up version of the voices of a mensural piece and we are using barlines to visualize the alignment, to facilitate locating the place where the voices are not lined up correctly due to a missing dot of division, missing notes, etc. The issue is that if we add those missing notes, sometimes the barline (used only as an aid to visualize the voice alignment) falls between the corrected notes (and that is why it ends up inside the
Would this affect the place where the barline is rendered? We want them to be rendered in the right place to show the note groupings. Looking back to the first example I presented: <staff n="2">
<layer n="1">
<note xml:id="m-11" dur="brevis" oct="4" pname="c" dur.quality="imperfecta" num="3" numbase="2"/>
<choice>
<corr>
<note xml:id="m-12a" dur="semibrevis" oct="4" pname="c"/>
<dot xml:id="m-12b" form="div"/>
<barLine form="dashed"/> <!-- IF YOU TAKE OUT THIS, THE ALIGNMENT WILL WORK AGAIN -->
<note xml:id="m-12c" dur="semibrevis" oct="4" pname="c"/>
</corr>
<sic>
<note xml:id="m-12" dur="semibrevis" oct="4" pname="c"/>
</sic>
</choice>
<choice>
<corr>
<note xml:id="m-13a" dur="semibrevis" oct="4" pname="c"/>
<note xml:id="m-13b" dur="semibrevis" oct="4" pname="c"/>
</corr>
<sic>
<note xml:id="m-13" dur="semibrevis" oct="4" pname="c"/>
</sic>
</choice>
<barLine form="dashed"/>
<note xml:id="m-14" dur="brevis" oct="4" pname="c"/>
<barLine form="dashed"/>
<note xml:id="m-15" dur="brevis" oct="4" pname="c"/>
<barLine form="dashed"/>
</layer>
</staff> Here the breve is perfect, we want to bar the piece by the breve to show the perfect groups of semibreves and facilitate observing if the barlines in all voices do line up (to facilitate finding out where a note was given the wrong duration by the scoring-up algorithm). In this example, we want the barline to be rendered just after that dot of division in the bassus. So, if the barline appears in a different place, that is an issue. I was trying to follow your proposed solution (adding the barline after Do you have other proposals that I can test? Thanks, @rettinghaus. |
@martha-thomae @lpugin Thanks - yes I agree that this probably would not occur that often (or at least there wouldn't be several measures in a row ending within a single correction) so I think this proposed solution will work. |
Fixed with #3852 |
There is an issue when a barline appears within a
<corr>
element.For the Measuring Polyphony Project, we add dotted barlines to show the alignment of notes. For some reason, if a barline falls within a
<corr>
element, the alignment gets messed up (empty spaces are inserted or notes switch to another staff when rendering).Here is an example of this (where empty spaces are inserted in rendering):
This is how this file gets displayed in Verovio:
If we remove the
<barline>
element from<corr>
(see commented line), then the alignment gets fixed:The text was updated successfully, but these errors were encountered: