Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Configuration Option dataUri not working #185

Open
gerome-avec-un-g opened this issue Apr 20, 2021 · 5 comments
Open

Maven Configuration Option dataUri not working #185

gerome-avec-un-g opened this issue Apr 20, 2021 · 5 comments

Comments

@gerome-avec-un-g
Copy link

Hello,

It seems that the option to embbed images as data uri in HTML documents does not work. In fact it doesn't seem to exist at all in \com\github\cukedoctor\cukedoctor-maven-plugin\3.5.2\cukedoctor-maven-plugin-3.5.2.jar!\META-INF\maven\plugin.xml

The following Maven configuration is shown in error in my IDE :

com.github.cukedoctor cukedoctor-maven-plugin 3.5.2 documents html left true true true true true execute verify

Thanks

@gerome-avec-un-g
Copy link
Author

Sorry, the code as been edited out...
<plugin> <groupId>com.github.cukedoctor</groupId> <artifactId>cukedoctor-maven-plugin</artifactId> <version>3.5.2</version> <configuration> <outputDir>documents</outputDir> <format>html</format> <toc>left</toc> <numbered>true</numbered> <hideScenarioKeyword>true</hideScenarioKeyword> <hideStepTime>true</hideStepTime> <hideSummarySection>true</hideSummarySection> <dataUri>true</dataUri> </configuration> <executions> <execution> <goals> <goal>execute</goal> </goals> <phase>verify</phase> </execution> </executions> </plugin>

@andrewesweet
Copy link
Contributor

Hi. Thanks for reporting this. The dataUri feature has not yet been released. It was merged to the mainline a week ago but the latest release (3.5.2) was two months than ago.

@rmpestano, when do you plan on pushing a new release, please?

@rmpestano
Copy link
Owner

Hey guys, I'll release 3.6.0 today and let you know here when it's synced into central.

@rmpestano
Copy link
Owner

3.6.0 should be on maven central now, let me know if it works for you

@gerome-avec-un-g
Copy link
Author

gerome-avec-un-g commented Apr 21, 2021

Hi,

3.6.0 fixes the issue with Maven, the dataUri option is available.

I still have an usage issue : where should I put my images in a standard Maven projet ?

I've tried the following :
src/test/resources/features/businessdomain
+---BusinessDomainFunctionality.feature
+---image.jpg

with
image::image.jpg[]

and only <img src="data:image/jpg;base64," alt="frais de garde pdf"> has been generated in the html code.

Thanks for your answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants