New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve auto drive logic #7

Open

rnd-ash opened this issue Feb 27, 2022 · 1 comment

Assignees

Labels

enhancement help wanted

Owner

rnd-ash commented Feb 27, 2022

Currently, all 3 automatic profiles (C/S/A) all use the same algorithm for calculating auto shift points.

Take engine RPM tachometer as a dial from 0-100%
Take pedal position as a percentage from 0-100%

If pedal percentage is more than 2x that of engine RPM percentage, then downshift
If engine RPM is greater than pedal position, upshift

This is super undesirable as it creates a lot of random up/down shifting

rnd-ash added enhancement help wanted labels

rnd-ash self-assigned this

viper-666 commented Jan 7, 2023 •

edited

Loading

I think it should up/downshift with fixed points who are different by profile (C/S/A).
There have to be three shift points

min rpm (before shifting down)
should be rpm (what is the goal to reach when cruising)
max rpm (at what it upshifts).
I mean something like that in comfort shift up if rpm is greater than 3000rpm or shift up earlier when the driver don't accelerate and is above "should be" rpm (+/- maybe 100rpm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment