Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasNestedSortableFix check not working for versions past 1.8.24 #174

Open
imahassle opened this issue Aug 24, 2016 · 0 comments
Open

hasNestedSortableFix check not working for versions past 1.8.24 #174

imahassle opened this issue Aug 24, 2016 · 0 comments

Comments

@imahassle
Copy link

I am using jQuery UI version 1.10.1, which definitely has the nested sortable fix added in 1.8.24.

However, the logic determining hasNestedSortableFix evaluates to -1, which later evaluates to false (used as !hasNestedSortableFix), since !-1 is false.

hasNestedSortableFix = version && version.indexOf("1.6.") && version.indexOf("1.7.") && (version.indexOf("1.8.") || version === "1.8.24");

As a result, I am encountering some pretty funky behavior (extra elements being added to the dom, other elements being cloned and replaced and removed after an unrelated action), and my observable data model not being updated. Setting the hasNestedSortableFix to false fixes this, since later this is negated to true.

I would request a fix in the version checking logic to allow for higher versions of jQuery UI which have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant