You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
Thanks for this excellent library! We've just started using in all our clients for our backup service https://degoo.com and it has helped us speed up our progress calculations a lot.
When profiling I noticed that (at least in our use case) it spends quite a lot of time calling this.success.get(character) in State. In our case >50% of all execution time is spent there. My hunch is that this could be improved quite a lot by using Trove's TCharObjectHashMap. It would add an external dependency but it might be worth it if the performance enhancement is big enough. If adding an external dependency is not an option perhaps implementing something similar to TCharObjectHashMap would be a better solution. Let me know if we can be of any assistance with this.
Regards
Carl Hasselskog
The text was updated successfully, but these errors were encountered:
In my experience, the alternative collections libaries like Trove, Goldman Sachs, HFTC, etc can sometimes perform better when primitives are involved. I don't know the details of why--avoiding unboxing? different hashing techniques? No clue.
I tried Carl's suggestion and used a TCharObjectHashMap to benchmark one of my usecases, where the trie has 200K case-sensitive keywords. It reduced parseText time by about 6%, but increased the time spent in building the trie by about 30%. I'm parsing terabytes of text, so for me even 6% is a big win.
Hi,
Thanks for this excellent library! We've just started using in all our clients for our backup service https://degoo.com and it has helped us speed up our progress calculations a lot.
When profiling I noticed that (at least in our use case) it spends quite a lot of time calling this.success.get(character) in State. In our case >50% of all execution time is spent there. My hunch is that this could be improved quite a lot by using Trove's TCharObjectHashMap. It would add an external dependency but it might be worth it if the performance enhancement is big enough. If adding an external dependency is not an option perhaps implementing something similar to TCharObjectHashMap would be a better solution. Let me know if we can be of any assistance with this.
Regards
Carl Hasselskog
The text was updated successfully, but these errors were encountered: