Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyflakes tests #76

Open
virtuald opened this issue Mar 10, 2017 · 1 comment
Open

Add pyflakes tests #76

virtuald opened this issue Mar 10, 2017 · 1 comment

Comments

@virtuald
Copy link
Member

pyflakes only detects things that are actually code errors (well... mostly), and it's pretty fast. Should add this in the future.

I think I would have it separate from the tests, as most of the things that pyflakes catches are things that are almost certainly errors.

@virtuald virtuald added this to the 2018.0.0 milestone Mar 10, 2017
@auscompgeek auscompgeek removed this from the 2018.1.0 milestone Jan 30, 2019
@auscompgeek
Copy link
Member

Note that pyflakes will emit warnings such as these too:

tests/pyfrc_test.py:6:1: 'from pyfrc.tests import *' used; unable to detect undefined names
tests/pyfrc_test.py:6:1: 'pyfrc.tests.*' imported but unused

flake8 assigns those error codes F403 and F401 respectively. ruff emits the first error, but not the second for some reason (which is probably a bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants