Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for config errors #27

Open
pavangudiwada opened this issue Jun 9, 2024 · 1 comment
Open

Improve error messages for config errors #27

pavangudiwada opened this issue Jun 9, 2024 · 1 comment

Comments

@pavangudiwada
Copy link
Contributor

If you don't have an OpenAI API key defined in the config.yaml holmes crashes with this error. I think it should show users a proper error that the key is missing.

╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ in ask:137                                                                                       │
│                                                                                                  │
│ in load_from_file:210                                                                            │
│                                                                                                  │
│ in load_model_from_file:41                                                                       │
│                                                                                                  │
│ in __init__:55                                                                                   │
│                                                                                                  │
│ in __init__:11                                                                                   │
│                                                                                                  │
│ in __init__:11                                                                                   │
│                                                                                                  │
│ in __init__:8                                                                                    │
│                                                                                                  │
│ in __init__:20                                                                                   │
│                                                                                                  │
│ in _decode_init:31                                                                               │
│                                                                                                  │
│ in _decode:53                                                                                    │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
ValueError: Invalid data type: <class 'NoneType'>, expected dict or list.
[32275] Failed to execute script 'holmes' due to unhandled exception!

Tested on Fedora Linux 40 (Workstation Edition)

@michael12312
Copy link

Created PR to fix this: #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants