Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links currently aren't working correctly. #40

Open
carlos-alberto opened this issue Jan 4, 2017 · 2 comments
Open

Links currently aren't working correctly. #40

carlos-alberto opened this issue Jan 4, 2017 · 2 comments

Comments

@carlos-alberto
Copy link
Contributor

We currently return both relative and absolute URL's, the docs are not clear on which is correct for jsonapi.

Also some links are urlencoded and some are not.

@carlos-alberto
Copy link
Contributor Author

@carlos-alberto
Copy link
Contributor Author

Example of the urlencoding issue:

    "first": "http://blah.com?page%5Bnumber%5D=1&page%5Bsize%5D=10", 
    "last": "http://blah.com?page%5Bnumber%5D=29&page%5Bsize%5D=10", 
    "next": "http://blah.com?page%5Bnumber%5D=29&page%5Bsize%5D=10", 
    "prev": "http://blah.com?page%5Bnumber%5D=27&page%5Bsize%5D=10", 
    "self": "http://blah.com?page[number]=28&page[size]=10"

again, we should choose one and stick with it (hopefully jsonapi spec will help us choose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant