☂️ Linter, port eslint's recommended preset

[ematipico]

Description

This umbrella is meant to track all the rules that belong to the recommended preset of ESLint and move them to Rome.

Some rules already exist and they might have a different names.

You can use this project to better track the progress.

[This spreadsheet] tracks all of them, with the relative rule in Rome.

The community might decide to split some rules into multiple rules, for different reasons:

• technical constraints (using different query systems in one rule is not possible in Rome);
• break down the scope of a rule into more specialized rules (for example in 📎 Lint cases similar to no-dupe-keys #3731 there was a discussion that ended up splitting a rule into multiple rules);
• our grouping system might not fit a rule;

Contribution guidelines

Always refer to our contribution guidelines when implementing the rule.

When porting a rule, make sure that the name of the rule reflects our internal naming patterns, and refrain from using abbreviations in the name of the rule. We try to promote complete names whenever it's possible.

Each task has an associated label that will mark its difficulty in implementing the rule. The difficulty has been assessed roughly by looking at ESLint implementation (their source code), so it's not bulletproof.

Any questions regarding a rule (technical or not) should be posted in the issue of the rule.

Remaining rules

• useSimpleNumberKeys #3888
• useLiteralKeys #3889
• noUnreachableSuper #3481

List of rules

This list doesn't contain the recommended rules that belong to the layout/formatting section.
Below, is the list of recommended rules that haven't been implemented yet.

• noControlCharactersInRegex, no-control-regex #3962
• noDuplicateCase, no-duplicate-case #3969
• noDuplicateElseIf, no-dupe-else-if #3967
• noClassAssign, no-class-assign #3970
• noConstantCondition, no-constant-condition #3961
• noEmptyCharacterClassInRegex no-empty-character-class #3972
• noFallthoughSwitchClause, no-fallthrough #3973
• noInnerDeclarations, no-inner-declarations #3974
• noIrregularWhitespace, no-irregular-whitespace #3975
• noMisleadingCharacterClassInRegex, no-misleading-character-class #3976
• noGlobalObjectCalls, no-obj-calls #3977
• noPrototypeBuiltins, no-prototype-builtins  #3979
• noSelfAssign, no-self-assign #3980
• noSelfCompare, no-self-compare #3982
• noThisBeforeSuper, no-this-before-super #3983
• noUnexpectedMultiline, no-unexpected-multiline  #3984
• noUnsafeOptionalChain, no-unsafe-optional-chaining #3985
• noUselessBackreference, no-useless-backreference #3986
• noNotANumberPrimitive, use-isnan #3987
• noExtraSemicolons, no-extra-semi #3988
• noNonoctalDecimalEscape, no-nonoctal-decimal-escape #3989
• noRedeclaration, no-redeclare #3990
• noUnusedLabel, no-unused-labels #3991
• noUselessEscape, no-useless-escape #3992
• noWith, no-with #3993
• useYield, require-yield #3994
• noAssignInExpression, no-cond-assign #4013

[mzbac]

Is it possible to categorize the rule into different difficulty groups? So people would know how to pick it up based on their level. I am pretty new to Rome and Rust, so I had a lot of trouble picking the right issue to contribute.

[ematipico]

Is it possible to categorize the rule into different difficulty groups? So people would know how to pick it up based on their level. I am pretty new to Rome and Rust, so I had a lot of trouble picking the right issue to contribute.

Yes, that's what I plan to do with each rule, I started doing so with the Accessibility rules.