🐛 12.1.0: Single quote style applied to JSX elements

[gkiely]

Environment information

Error when running rome rage

What happened?

// rome.json

{
  "javascript": {
    "formatter": {
      "quoteStyle": "single"
    }
  }
}

// App.tsx
<div className='myClass'></div>

Expected result

// App.tsx
<div className="myClass"></div>

Code of Conduct

• I agree to follow Rome's Code of Conduct

[nissy-dev]

This is intentional behavior. Rome doesn't treat JSX attributes specially (it means that JSX attribute values also are formatted based on "quoteStyle" setting).
ref: #4054 and threads based on #2465 (comment)

[gkiely]

@nissy-dev I hope the team reconsiders, it is a popular choice for developers.

[ematipico]

@nissy-dev I hope the team reconsiders, it is a popular choice for developers.

Please refer to the discussion: prettier regrets having some of those options, they create too much bikeshedding and they are difficult to justify.

[nstepien]

Is parity with Prettier not a goal anymore?
I'm worried deviating from Prettier would make it harder to adopt Rome's formatting in large codebases.

Maybe a jsxQuoteStyle option may be worth it, doesn't seem like a significant maintenance burden, but I could be wrong.

[ematipico]

Is parity with Prettier not a goal anymore? I'm worried deviating from Prettier would make it harder to adopt Rome's formatting in large codebases.

Maybe a jsxQuoteStyle option may be worth it, doesn't seem like a significant maintenance burden, but I could be wrong.

The parity makes sense, but it doesn't make sense to repeat the mistakes that a tool did; it would be a bit unfortunate to carry over those here.

We are always open to suggestions! Does it make sense to treat JSX quotes differently from the rest of other quotes? Why? Would that cause more friction in terms of maintainability, bugs, etc.? Would that create bike-shedding or not? If someone feels strongly, they can always open a discussion! :)

[nstepien]

it doesn't make sense to repeat the mistakes that a tool did

What may have been a mistake in the past has now become standard. 🤷‍♂️
The React docs themselves use double quotes for jsx props, and single quotes otherwise.
I think the idea may have been that HTML is usually formatted with double quotes, so the habit stuck with JSX.
That's my 2 cents.

[ematipico]

Makes sense, we should open an issue

[nstepien]

@ematipico I've opened #4486