Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Rome do not have the quick actions for lint style rules - Must be write in hand on VsCode #4765

Closed
1 task done
harrytran998 opened this issue Aug 11, 2023 · 5 comments
Labels
S-To triage Status: user report of a possible bug that needs to be triaged

Comments

@harrytran998
Copy link

harrytran998 commented Aug 11, 2023

Environment information

CLI:
  Version:                      12.1.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.16.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.6.12"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      <=10.0.0

What happened?

image

I don't remember yet, but in some Rome versions, when I toggle quick actions on Vscode --> Rome will have a hint to write the disabled comment on the top of the line.

Like this

  if (param === "") {
    // rome-ignore lint/style/noParameterAssign: Reason
    param = "preset";
  }

Here is my rome config

{
  "$schema": "./node_modules/rome/configuration_schema.json",
  "vcs": {
    "enabled": true,
    "clientKind": "git"
  },
  "organizeImports": {
    "enabled": true,
    "ignore": ["coverage", "cache"]
  },
  "formatter": {
    "enabled": true,
    "indentSize": 2,
    "indentStyle": "space",
    "lineWidth": 100,
    "formatWithErrors": false
  },
  "linter": {
    "enabled": true,
    "rules": {
      "a11y": {
        "recommended": true
      },
      "complexity": {
        "recommended": true
      },
      "nursery": {
        "recommended": true
      },
      "correctness": {
        "recommended": true
      },
      "style": {
        "recommended": true
      },
      "suspicious": {
        "recommended": true,
        "noExplicitAny": "warn"
      },
      "performance": {
        "recommended": true
      }
    }
  },
}

Expected result

Well, might be I missed something or this was a bug. Hopefully, your team can take a look!
Thanks.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@harrytran998 harrytran998 added the S-To triage Status: user report of a possible bug that needs to be triaged label Aug 11, 2023
@ematipico
Copy link
Contributor

@harrytran998

For the future:

  • do not cut the Rome rage command output. The header of the output contains valuable information that we need. You removed the part that says which version of Rome you're using :) It's fine to remove the logs, though.
  • second, check the log
Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      <=10.0.0

It seems you are running a daemon that is incompatible with the CLI installed. Make sure to kill the process it and restart the editor. That should fix it.

@harrytran998
Copy link
Author

harrytran998 commented Aug 12, 2023

Thank you @ematipico for the quick response! My fault to cut this off, because I run this comment in the terminal --> The log is so long...

But after reading your response, I return to the VsCode --> Rome rage again --> Here is the result.

CLI:
  Version:                      12.1.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.16.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.6.12"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      <=10.0.0

Hope you can check this

@ematipico
Copy link
Contributor

ematipico commented Aug 12, 2023

From #4765 (comment)

It seems you are running a daemon that is incompatible with the CLI installed. Make sure to kill the process it and restart the editor. That should fix it.

Have you tried this?

@harrytran998
Copy link
Author

harrytran998 commented Aug 12, 2023

Yes, I restart my computer and tried again, but no luck. Even I try to restart Rome LSP from Command Pallete of VsCode --> Doesnt work! So can I provide you with some information to trace this? Might be a video recording? @ematipico

@harrytran998
Copy link
Author

Hmm, I know the issue! I can toggle Rome when have some fixable lint like Template Literature, but style/noParameterAssign doesn't have suggestions 🤔.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-To triage Status: user report of a possible bug that needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants