-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log discrepancy when setting MPPI parameters dynamically #4704
Comments
You should see a log that Can you submit a PR that creates a |
I see your PR, this can be backported so once its merged into main, I'll autobackport into Humble/Iron/Jazzy |
The "verbose" parameter of the parameters_handler is a special case that needs registration before the dynamic parameter handler callback is registered. In verbose mode make the parameter handler info/warn/debug messages more expressive.
This is one of the first things I played with understanding when getting my head into the mppi code. Here is a cleaned up patch that helps explain what is happening with the "verbose" parameter that may help shed some clarity. |
The "verbose" parameter of the parameters_handler is a special case that needs registration before the dynamic parameter handler callback is registered. In verbose mode make the parameter handler info/warn/debug messages more expressive. Signed-off-by: Mike Wake <[email protected]>
* remove comments. * Use RCLCPP_DEBUG instead of INFO for low level messages. * Add test for trying to access parameters that are not declared. Signed-off-by: Mike Wake <[email protected]>
…os-navigation#4704) Attempts to change undefined parameters will not be successful and will log an error. Attempts to change static parameters will be ignored, a debug message is logged if a change in parameters is attempted.
…os-navigation#4704) Attempts to change undefined parameters will not be successful and will log an error. Attempts to change static parameters will be ignored, a debug message is logged if a change in parameters is attempted. Signed-off-by: Mike Wake <[email protected]>
Bug report
Required Info:
Operating System:
ROS2 Version:
Version or commit hash:
DDS implementation:
Steps to reproduce issue
Using
ros2 param set
command to set MPPI parameters triggers a NOT FOUND warning, although the command returns 'Set parameter successful'.Expected behavior
Actual behavior
Additional information
Seems like
parameters_handler
always returns success even though a parameter might not be found.The text was updated successfully, but these errors were encountered: