Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed updates for translations #308

Open
BrianCriswell opened this issue Jan 25, 2021 · 3 comments
Open

Needed updates for translations #308

BrianCriswell opened this issue Jan 25, 2021 · 3 comments

Comments

@BrianCriswell
Copy link
Member

After going through the French language file in #281, I realized a few enhancements are needed for translation purposes.

  • \damagename needs to be parameterized so that "fire damage" can become "dégâts de feu".
  • Whereas the English version has every header in a monster stat block as the plural form of the word, the French translation will use singular or plural based on whether there is one or more of the thing. For instance, saving throws can be "Compétence" or "Compétences". We could do a detection of singular or plural based on commas, similarly to how we detect whether a spell list has more than 1 spell in it to determine which version of number/day to use innate spellcasting.
@BrianCriswell
Copy link
Member Author

If there are enhancements needed for other language translations, please add them to this issue.

This was referenced Jan 25, 2021
@jeandeaual
Copy link
Contributor

jeandeaual commented Jan 26, 2021

Following up on #310.

  • \tocchapterabbreviationname{Ch.} needs a reference to the chapter number for the translation: 第|1|章
  • \pageabbreviationname{pg.} needs a reference to the page number: |1|ページ
  • The following translations need to have the colon added to them (with an update required in Japanese update #310):
    • \innateatwillname
    • \numberperdayname
    • \numberperdayeachname
  • The following translations already have a Japanese colon (:) in them, so the colon should be attend to the translation. Also, them seem to have been parameterized recently, so we might need to include the parameter in the Japanese translation:
    • \meleeattackname
    • \rangedattackname
    • \meleeorrangedattackname
  • Ideally, the spaces around \xpname, \unitsname, \orname and \plusname (at least) should be part of the translation, since there is no space around them in Japanese. Same thing for the comma (、 in Japanese), the period (。 in Japanese), the plus sign (+ in Japanese) and the minus sign (- in Japanese):

@vonBarbarosa
Copy link
Contributor

Portuguese and Spanish languages also need the two features mentioned for French.

This would solve issue #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants