Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle different versions of Lemmy Server #38

Open
fishcharlie opened this issue Aug 5, 2023 · 1 comment
Open

Handle different versions of Lemmy Server #38

fishcharlie opened this issue Aug 5, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@fishcharlie
Copy link
Member

Lemmy 0.18.0 to 0.18.3 removed a required property in the API, which caused decoding to fail. It feels like the Lemmy API is incredibly unstable between versions.

We need to figure out how to make this more stable and not throw errors between different server versions.

Some ideas:

  • Make every property optional
  • Have defaults for each property if decoding fails (ie. empty strings if decoding fails)

Any suggestions on how the community would like to see this handled would be appreciated.

@fishcharlie fishcharlie added the help wanted Extra attention is needed label Aug 5, 2023
@jstayco
Copy link

jstayco commented Aug 17, 2023

Sorry, just now seeing this as servers have bumped their versions. If you're still looking for opinions, I think I'd rather see optional properties, so that clients can wrap that however they need to based on the failure as opposed to having to check for default values which might be unique to your library. That second option would require downstream users to have to dive into documentation or source to figure out what they should be matching against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants