From 85908d509a55e783001972125ad4ea4f569ec9b4 Mon Sep 17 00:00:00 2001 From: Remi Rousselet Date: Sat, 10 Feb 2024 16:38:31 +0100 Subject: [PATCH] Update goldens --- ...rt_class_based_provider_to_functional.diff | 15 ++++++ .../lints/functional_ref/functional_ref.diff | 46 +++++++++++++++++++ .../lints/functional_ref/functional_ref.json | 1 - .../functional_ref/functional_ref_test.dart | 2 +- .../notifier_extends/notifier_extends.diff | 40 +++++++++++++++- 5 files changed, 100 insertions(+), 4 deletions(-) create mode 100644 packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.diff delete mode 100644 packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.json diff --git a/packages/riverpod_lint_flutter_test/test/assists/convert_class_based_provider_to_functional/convert_class_based_provider_to_functional.diff b/packages/riverpod_lint_flutter_test/test/assists/convert_class_based_provider_to_functional/convert_class_based_provider_to_functional.diff index 18766d6a1..d32463fb6 100644 --- a/packages/riverpod_lint_flutter_test/test/assists/convert_class_based_provider_to_functional/convert_class_based_provider_to_functional.diff +++ b/packages/riverpod_lint_flutter_test/test/assists/convert_class_based_provider_to_functional/convert_class_based_provider_to_functional.diff @@ -59,5 +59,20 @@ Diff for file `test/assists/convert_class_based_provider_to_functional/convert_c + // Hello world + return 0; + } + +@riverpod +``` +--- +Message: `Convert to functional provider` +Priority: 100 +Diff for file `test/assists/convert_class_based_provider_to_functional/convert_class_based_provider_to_functional.dart:23`: +``` + +@riverpod +- class Generic extends _$Generic { +- @override +- int build() => 0; +- } ++ int generic(GenericRef ref) => 0; ``` --- diff --git a/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.diff b/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.diff new file mode 100644 index 000000000..f45973703 --- /dev/null +++ b/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.diff @@ -0,0 +1,46 @@ +Message: `Type as NamelessRef` +Priority: 90 +Diff for file `test/lints/functional_ref/functional_ref.dart:8`: +``` +int nameless( + // expect_lint: functional_ref +- ref, ++ NamelessRef ref, +) { + return 0; +``` +--- +Message: `Type as NoGenericsRef` +Priority: 90 +Diff for file `test/lints/functional_ref/functional_ref.dart:21`: +``` +@riverpod +// expect_lint: functional_ref +- int noGenerics(NoGenericsRef ref) => 0; ++ int noGenerics(NoGenericsRef ref) => 0; + +@riverpod +``` +--- +Message: `Type as MissingGenericsRef` +Priority: 90 +Diff for file `test/lints/functional_ref/functional_ref.dart:25`: +``` +@riverpod +// expect_lint: functional_ref +- int missingGenerics(MissingGenericsRef ref) => 0; ++ int missingGenerics(MissingGenericsRef ref) => 0; + +@riverpod +``` +--- +Message: `Type as WrongOrderRef` +Priority: 90 +Diff for file `test/lints/functional_ref/functional_ref.dart:29`: +``` +@riverpod +// expect_lint: functional_ref +- int wrongOrder(WrongOrderRef ref) => 0; ++ int wrongOrder(WrongOrderRef ref) => 0; +``` +--- diff --git a/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.json b/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.json deleted file mode 100644 index 4def516b2..000000000 --- a/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref.json +++ /dev/null @@ -1 +0,0 @@ -[{"priority":90,"change":{"message":"Type as NamelessRef","edits":[{"fileStamp":0,"edits":[{"offset":154,"length":0,"replacement":"NamelessRef "}]}],"linkedEditGroups":[]}},{"priority":90,"change":{"message":"Type as NoGenericsRef","edits":[{"fileStamp":0,"edits":[{"offset":357,"length":14,"replacement":"NoGenericsRef "}]}],"linkedEditGroups":[]}},{"priority":90,"change":{"message":"Type as MissingGenericsRef","edits":[{"fileStamp":0,"edits":[{"offset":450,"length":19,"replacement":"MissingGenericsRef "}]}],"linkedEditGroups":[]}},{"priority":90,"change":{"message":"Type as WrongOrderRef","edits":[{"fileStamp":0,"edits":[{"offset":543,"length":14,"replacement":"WrongOrderRef "}]}],"linkedEditGroups":[]}}] \ No newline at end of file diff --git a/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref_test.dart b/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref_test.dart index 1930729cc..ba343372d 100644 --- a/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref_test.dart +++ b/packages/riverpod_lint_flutter_test/test/lints/functional_ref/functional_ref_test.dart @@ -8,7 +8,7 @@ import '../../golden.dart'; void main() { testGolden( 'Verify that @riverpod classes extend the generated typedef', - 'lints/functional_ref/functional_ref.json', + 'lints/functional_ref/functional_ref.diff', sourcePath: 'test/lints/functional_ref/functional_ref.dart', (result) async { final lint = FunctionalRef(); diff --git a/packages/riverpod_lint_flutter_test/test/lints/notifier_extends/notifier_extends.diff b/packages/riverpod_lint_flutter_test/test/lints/notifier_extends/notifier_extends.diff index 985408240..c0eea862c 100644 --- a/packages/riverpod_lint_flutter_test/test/lints/notifier_extends/notifier_extends.diff +++ b/packages/riverpod_lint_flutter_test/test/lints/notifier_extends/notifier_extends.diff @@ -1,6 +1,6 @@ Message: `Extend _$NoExtends` Priority: 90 -Diff for file `test/lints/notifier_extends/notifier_extends.dart:12`: +Diff for file `test/lints/notifier_extends/notifier_extends.dart:14`: ``` @riverpod // expect_lint: notifier_extends @@ -12,7 +12,7 @@ Diff for file `test/lints/notifier_extends/notifier_extends.dart:12`: --- Message: `Extend _$WrongExtends` Priority: 90 -Diff for file `test/lints/notifier_extends/notifier_extends.dart:18`: +Diff for file `test/lints/notifier_extends/notifier_extends.dart:20`: ``` @riverpod // expect_lint: notifier_extends @@ -22,3 +22,39 @@ Diff for file `test/lints/notifier_extends/notifier_extends.dart:18`: } ``` --- +Message: `Extend _$NoGenerics` +Priority: 90 +Diff for file `test/lints/notifier_extends/notifier_extends.dart:38`: +``` +@riverpod +// expect_lint: notifier_extends +- class NoGenerics extends _$NoGenerics { ++ class NoGenerics extends _$NoGenerics { + int build() => 0; +} +``` +--- +Message: `Extend _$MissingGenerics` +Priority: 90 +Diff for file `test/lints/notifier_extends/notifier_extends.dart:44`: +``` +@riverpod +// expect_lint: notifier_extends +- class MissingGenerics extends _$MissingGenerics { ++ class MissingGenerics extends _$MissingGenerics { + int build() => 0; +} +``` +--- +Message: `Extend _$WrongOrder` +Priority: 90 +Diff for file `test/lints/notifier_extends/notifier_extends.dart:50`: +``` +@riverpod +// expect_lint: notifier_extends +- class WrongOrder extends _$WrongOrder { ++ class WrongOrder extends _$WrongOrder { + int build() => 0; +} +``` +---