New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnumerableExtensions.MinBy and MaxBy throw when collection has only null values #135

Open

NN--- opened this issue Jun 12, 2021 · 2 comments

Member

NN--- commented Jun 12, 2021

string?[] a = { null, null };
var m = a.MinBy(x => x); // throws no InvalidOperationException collection has no elements.

This happens since the methods looks for non default value while the correct is to have an indicator for not empty enumeration.

Member Author

NN--- commented Jun 12, 2021

https://github.com/microsoft/referencesource/blob/5697c29004a34d80acdaf5742d7e699022c64ecd/System.Core/System/Linq/Enumerable.cs#L1540

Member Author

NN--- commented Aug 31, 2021

https://docs.microsoft.com/en-us/dotnet/api/system.linq.enumerable.minby?view=net-6.0
https://docs.microsoft.com/en-us/dotnet/api/system.linq.enumerable.maxby?view=net-6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment