Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support repository names with commas #620

Closed
wants to merge 1 commit into from
Closed

support repository names with commas #620

wants to merge 1 commit into from

Conversation

aronatkins
Copy link
Contributor

This change adds repository name support to lockfile parsing without
introducing quoting or escaping. It assumes that URLs may be part of repository
names but are unlikely to occur in repository URLs.

This means that a repository value of:

A=B,C,D=E

is interpreted as:

A=B
"C,D"=E

We will need to introduce quoting / escaping if we encounter commas in URLs as
well as repository names.

fixes #587

This change adds repository name support to lockfile parsing without
introducing quoting or escaping. It assumes that URLs may be part of repository
names but are unlikely to occur in repository URLs.

This means that a repository value of:

    A=B,C,D=E

is interpreted as:

    A=B
    "C,D"=E

We will need to introduce quoting / escaping if we encounter commas in URLs as
well as repository names.

fixes #587
@aronatkins aronatkins deleted the branch rstudio:master June 3, 2022 16:49
@aronatkins aronatkins closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repos ambiguous in lockfile when name includes a comma
1 participant