Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does your project structure differ now with the 0.19 release? #53

Open
nullbio opened this issue Aug 27, 2018 · 6 comments
Open

How does your project structure differ now with the 0.19 release? #53

nullbio opened this issue Aug 27, 2018 · 6 comments

Comments

@nullbio
Copy link

nullbio commented Aug 27, 2018

Hi @rtfeldman, just wondering if you're planning on updating your article to elaborate on your new project structure for the 0.19 release? https://dev.to/rtfeldman/tour-of-an-open-source-elm-spa -- Noticed that your new commits have a significantly different project structure. Thanks.

@abradley2
Copy link

I'm most curious about the use of the Api modules and Api.application

@Kurren123
Copy link

Kurren123 commented Oct 12, 2018

He did admit that when upgrading to 0.19 he "completely rearchitected everything" :-)

@rtfeldman I'd love to know the reasons for these changes, maybe we all can learn from them.

@jinjor
Copy link

jinjor commented Nov 22, 2018

The most interesting thing for me is the change from Task to Cmd in each page 🙂

@tekul
Copy link

tekul commented Apr 14, 2019

My understanding of the switch from Task to Cmd for each page is that previously, the transition to the page would not take place until all the data had loaded for it (the Task was responsible for creating the page model). Now the transition takes place immediately, and the page model keeps track of the loading state of its individual parts (usually called Status). See this part of the Home page model for example.

The benefit is that if there are multiple parts to a page, the user can see the loaded bits immediately. For example they can start reading an article without having to wait for the comments to load. Previously, they would be stuck on the original page waiting for the transition to take place.

@frederikhors
Copy link

frederikhors commented Apr 28, 2019

The benefit is that if there are multiple parts to a page, the user can see the loaded bits immediately. For example they can start reading an article without having to wait for the comments to load. Previously, they would be stuck on the original page waiting for the transition to take place.

@tekul but this is not what it seems here, right? https://elm-spa-example.netlify.com/

@tekul
Copy link

tekul commented Apr 28, 2019

@frederikhors Not sure what you mean by "not what it seems here". That's the new version - it loads the page immediately then loads the content (the feed and tags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants