Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document official guidance on dealing with external signature errors #2121

Open
aaronmallen opened this issue Dec 5, 2024 · 0 comments
Open

Comments

@aaronmallen
Copy link

aaronmallen commented Dec 5, 2024

What is the official guidance on dealing with signature errors from dependencies? For example the signatures for Gem::Specification claim that Gem::Specification does not have the singleton method load (it does). The signatures for system claim that system does not accept the keyword argument exception (it also does). The rbs collection thor signatures are all but useless and missing most of thor core functionality. I'm sure there are thousands of other issues like this which brings me to my point: What is the recommended approach for dealing with these issues? Are we expected to implement the signatures of our dependencies alongside our own gem signatures? Are we expected to just write or overload the missing or broken signatures in our own classes even though the methods don't technically belong to those classes? Are we expected to use untyped (even though this couldn't handle every use case)? Are we expected to implement interfaces that mimic our dependencies so as not to override the actual signatures from dependencies? Or is there some other work around the rbs team recommends? I'd love to see the answer from the rbs team to this question documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant