Case contact details ux improvements 5896 #5909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed asterisk from record contact details heading Added asterisks to subheadings to help users understand what needs to be filled out. (better user experience)
when user selects contact type on new contact page - modified '_contact_types.html.erb' to sort by last_contact_time - updated ContactTypeDecorator with last_contact_timestamp method to obtain last contact or default to a time in past if no contacts Change was made in order to ensure that 'ContactType' options are displayed for users in a way that allows them to quickly access recently used contact types vs scrolling through all options.
github-actions
bot
added
ruby
3 tasks
Added server side validation to the contact model in order to ensure that "Contact Type" is filled out as required field when user submits a new case contact details form
| @@ -3,7 +3,7 @@ | |||
| <%= render(Form::MultipleSelectComponent.new( | |||
| form: form, | |||
| name: :contact_type_ids, | |||
| options: options.decorate.map { |ct| ct.hash_for_multi_select_with_cases(casa_cases&.pluck(:id)) }, | |||
| options: options.decorate.sort_by { |ct| ct.last_contact_timestamp(casa_cases.pluck(:id)) }.reverse.map { |ct| ct.hash_for_multi_select_with_cases(casa_cases.pluck(:id)) }, | |||
There was a problem hiding this comment.
I think the ordering can be done in
There was a problem hiding this comment.
I tried to do this originally in the controller but couldn't get it to work. Any suggestions?
The decorator wasn't working correctly specifically if I remember right so the extra sorting logic there was added as a fix
|
This PR has been open for a long time without any pushes or comments! What's up? |
|
Hi @FireLemons apologies for the delay here. Let's chat about this tomorrow during office hours and I can get this restarted! |
|
This PR has been open for a long time without any pushes or comments! What's up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5896
What changed, and why?
3 main changes were made to the UX around creating contact details in order to improve UX and create a better experience for recorder.
How is this tested? (please write tests!) 💖💪
added rspec testing to case_contact_decorator spec to test new method
Screenshots please :)