Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom columns delimiters #143

Open
ghost opened this issue Jul 11, 2013 · 5 comments
Open

Support for custom columns delimiters #143

ghost opened this issue Jul 11, 2013 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 11, 2013

I have some examples of CSV files that use | as delimiter. It would be nice to be able to set it as an option.

@rufuspollock
Copy link
Contributor

@jackdbernier good point - we should probably allow you set any character for delimiter!

@ghost
Copy link
Author

ghost commented Jul 12, 2013

I might take a look later and propose a solution. Though I'm not used to work with backbone. This shouldn't be that hard.

@rufuspollock
Copy link
Contributor

You'll just want to tweak the code here I think https://github.com/okfn/dataexplorer/blob/master/src/views/load.js#L259

simplest option would be just add "|" to the list, more complex option is to make this generic in some way!

@rufuspollock
Copy link
Contributor

@jackdbernier any luck here?

@ghost
Copy link
Author

ghost commented Aug 2, 2013

We haven't got time to play a lot with the dataexplorer yet. Though, I tried to modify the code you pointed out with the dev console and it worked. So it will do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant