Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show QR Code in an overlay on website #241

Open
Gitoffthelawn opened this issue Jan 24, 2020 · 1 comment
Open

Option to show QR Code in an overlay on website #241

Gitoffthelawn opened this issue Jan 24, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Gitoffthelawn
Copy link
Contributor

Background

Feature Request: Add ability to show QR Code in an overlay

Proposed solution

The following Firefox extension accomplishes this nicely:
https://addons.mozilla.org/firefox/addon/qr-coder/
On GitHub, the source code is at: https://github.com/nunocunha/qr-coder

@Gitoffthelawn Gitoffthelawn added the enhancement New feature or request label Jan 24, 2020
@rugk rugk changed the title FR: Add ability to show QR Code in an overlay Option to show QR Code in an overlay on website Jan 24, 2020
@rugk
Copy link
Owner

rugk commented Jan 24, 2020

Originally, I've also had this idea, but really, what exactly is the advantage of using that instead of a popup? What difference does it make?

Also semantically/UI-wise popups are a good point to show extra information for a website as an add-on.

IMHO this is a nice-to-have feature, so I won't close it/reject it, but I treat it as very low-priority. I just don't think there is such a big (or any) advantage over the current solution. Also the implementation is likely quite hard as the add-on is quite coupled to using a popup for such things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants