Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching back to upstream kjua version #255

Open
rugk opened this issue Jul 26, 2020 · 2 comments
Open

Consider switching back to upstream kjua version #255

rugk opened this issue Jul 26, 2020 · 2 comments
Labels
code quality discuss me invitation to discuss this topic, this may need some more opinions enhancement New feature or request
Milestone

Comments

@rugk
Copy link
Owner

rugk commented Jul 26, 2020

Background

In #188 we switched to to https://github.com/werthdavid/kjua/, a fork of the kjua lib that initially mostly just added SVG support (see lrsjng/kjua#7)

Now, however, the upstream author also added SVG support in a smaller way without an extra lib.

Proposed solution

Switch back to https://github.com/lrsjng/kjua

Alternatives

Keep the fork by @werthdavid given it works. (and maybe has other advantages?)
AFAIK we, however, do not make use of other differences, e.g. a transparent background e.g. is usually always given if we use an SVG. (respectively we always need to specify a color 😉)

Additional context

This could also improve/fix #248, because of a smaller code base without so much eval etc.

@rugk rugk added enhancement New feature or request code quality discuss me invitation to discuss this topic, this may need some more opinions labels Jul 26, 2020
@rugk rugk added this to the next milestone Jul 26, 2020
@rugk

This comment has been minimized.

@rugk

This comment has been minimized.

@rugk rugk modified the milestones: 1.8, next Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality discuss me invitation to discuss this topic, this may need some more opinions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant