Added feature to copy QR to clipboard #304
Conversation
|
Hi @ketelaar,
About the clipboard API problem: did you know that web extensions have their own API for clipboard access? I used that in the emoji picker extension for coping the emoji, IIRC that API was only to be used when the address bar search is enabled and the emoji is intended to be copied there. Otherwise https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard may help. |
|
So I assume you do not want to continue this PR @ketelaar? |
This closes #285 but it has a caveat. This is because I used the Clipboard API in order to copy the QR code to the clipboard, which does not work by default in the current Firefox release. There is another way to implement this using
document.execCommand('copy')like this one, but I couldn't get it to work.When you set
dom.events.asyncClipboard.clipboardItemtotrueinabout:configthis functions works fine. The issue that is blocking it from being activated by default is being worked on, so this suggests that the requiredabout:configentry might be activated by default some time in the future.I'm not sure on how to proceed with this, should we maybe add a small description in the options to let users know how to activate it with the current (stable) version of Firefox?
Also, I tested this function on both Windows 11 22H2 and macOS Ventura 13.3 on Firefox 111.0.1 and 112.0b8 (Developer Edition) by pasting the copied image to LibreOffice Writer, which worked fine on both platforms and versions of Firefox.
If something needs to change or is a bit unclear, please let me know, I'll get back to you ASAP.