Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we export getTopKEmbeddings again? #1054

Open
parhammmm opened this issue Jul 18, 2024 · 1 comment
Open

Can we export getTopKEmbeddings again? #1054

parhammmm opened this issue Jul 18, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@parhammmm
Copy link
Contributor

In the latest release getTopKEmbeddings is no longer exported and moved to /internals but we we're using it in our setup.

My question is should I make a PR to export getTopKEmbeddings again and if so where would you want it to be placed
@parhammmm parhammmm changed the title Can we export getTopKEmbeddings? Can we export getTopKEmbeddings again? Jul 18, 2024
@himself65
Copy link
Member

You could expose it. There are many undocumented APIs, and some APIs shouldn't be exported by propose, but people use export *. So, if you want to make it stable, please write a test to stabilize it.

@himself65 himself65 added the good first issue Good for newcomers label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parhammmm @himself65