Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing stripInternal in tsconfig #1160

Open
ryanleecode opened this issue Sep 8, 2024 · 1 comment
Open

missing stripInternal in tsconfig #1160

ryanleecode opened this issue Sep 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ryanleecode
Copy link
Contributor

We are using @internal modifiers but we don't have stripInternal in any of the tsconfigs, so this is actually leaking into the d.ts.

https://github.com/run-llama/LlamaIndexTS/blob/main/packages/llamaindex/src/Settings.ts#L40
@himself65
Copy link
Member

yes but we are not actually taking this seriously for now. It's okay but evetuanlly I will enable it

@himself65 himself65 added the bug Something isn't working label Sep 10, 2024
himself65 added a commit to himself65/LlamaIndexTS that referenced this issue Sep 13, 2024
@himself65
chore: enable stripInternal
557bc22 
As we move modules into core, we can enable this now

Closes: run-llama#1160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@himself65 @ryanleecode