Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format request: Dhall #123

Open
passcod opened this issue Nov 4, 2019 · 6 comments · May be fixed by #466
Open

Format request: Dhall #123

passcod opened this issue Nov 4, 2019 · 6 comments · May be fixed by #466
Labels
A-format

Comments

@passcod
Copy link

passcod commented Nov 4, 2019

The Dhall configuration language. Rust implementation.

let user = "bill"
in  { home       = "/home/${user}"
    , privateKey = "/home/${user}/.ssh/id_ed25519"
    , publicKey  = "/home/${user}/.ssh/id_ed25519.pub"
    }
@matthiasbeyer
Copy link
Member

I'd love to review patches adding support for Dhall!

@passcod
Copy link
Author

passcod commented Mar 19, 2021

I'm actually not interested in Dhall as a useful configuration language anymore (happy to talk about this elsewhere) but will leave this open for others.

@sphw sphw mentioned this issue Jul 30, 2021
Closed
@polarathene polarathene linked a pull request Oct 4, 2023 that will close this issue
Open
@ChristopherRabotin
Copy link

Hi there,
I'm interested in this feature. Does it need a lot more work compared to @polarathene 's updated PR from last October or is that work essentially ready to merge?

Thanks

@polarathene
Copy link
Collaborator

updated PR from last October or is that work essentially ready to merge?

My PR should be fine with other ones I have open. I did a bit of refactoring for a more unified approach for serde based crates used and the Dhall PR should probably adapt to that.

My main PR for improving that was blocked by me on running some checks that I didn't get around to. I can try make time to come back to these, but the other issue you'd face is that this crate is no longer maintained AFAIK, not until some new maintainers are assigned / trusted.

@ChristopherRabotin
Copy link

ChristopherRabotin commented Jun 7, 2024 via email

@polarathene
Copy link
Collaborator

I may nominate myself to be the new maintainer

Of Dhall? or config-rs? (related issue)

I can look at pushing my PRs forward here, but I'm not sure if a new release will be made until the maintainer situation is sorted out. I don't have the time to maintain anymore projects myself unfortunately 😓

If Dhall becomes maintained, it'd be easier to get my PR for that approved. I don't know what the future is for this crate, so if no new maintainer steps up for config-rs it may be better to push the support to another popular config crate?

@epage epage added the A-format label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Dhall support polarathene/config-rs
Add Dhall support sphw/config-rs
5 participants
@epage @passcod @matthiasbeyer @ChristopherRabotin @polarathene