Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "Macros By Example" section to "Declarative Macros" #1515

Open
lolbinarycat opened this issue Jun 21, 2024 · 2 comments
Open

rename "Macros By Example" section to "Declarative Macros" #1515

lolbinarycat opened this issue Jun 21, 2024 · 2 comments

Comments

@lolbinarycat
Copy link

this terminology is rarely used outside of the reference, and is fairly confusing. it is especially easy to confuse this page for the rust by example page on macros.

proposed changes:

@0elek
Copy link

0elek commented Jul 8, 2024

"Macros By Example" is not just the name of the section but the type of macros that the macro_rules! produce. i don't think this need changing since its being explained in the first line.

@lolbinarycat
Copy link
Author

"Macros By Example" is not just the name of the section but the type of macros that the macro_rules! produce.

yes, i understand that, but that type of macro is much more commonly referred to as "declarative macros". "Macros By Example" is a confusing name, which is why most information on rust does not use it.

i don't think this need changing since its being explained in the first line.

just because something is explained in the reference doesn't mean it isn't confusing. the terminology in the reference should match that used by the rest of the community, and that is not the case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants